Test WebApplicationBuilder with WebApplicationFactory #63196
+37
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-mvc
There was a problem hiding this comment.
Pull Request Overview
This PR adds test coverage for WebApplicationBuilder with WebApplicationFactory and ensures continued test coverage for WebHostBuilder. The changes address a specific testing gap identified in issue #62782.
- Adds a new test
TestingInfrastructure_WebApplicationBuilder_RespectsCustomizationsto verifyWebApplicationBuilderworks correctly withWebApplicationFactory - Reverts
BasicWebSiteto useWebHostBuilderinstead ofHostBuilderto maintain test coverage for the deprecated pattern - Updates existing test assertions to distinguish between different
CreateServermethod overloads
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Mvc/test/WebSites/BasicWebSite/Program.cs | Reverted from HostBuilder to WebHostBuilder to maintain test coverage |
| src/Mvc/test/Mvc.FunctionalTests/TestingInfrastructureInheritanceTests.cs | Added new test for WebApplicationBuilder and updated assertions to track different server creation methods |
| factory.StartServer(); | ||
|
|
||
| // Assert | ||
| Assert.Equal(["ConfigureWebHost"], factory.ConfigureWebHostCalled.ToArray()); |
There was a problem hiding this comment.
[nitpick] Use collection expression syntax consistently. The array literal syntax ["ConfigureWebHost"] is being used here, but line 27 uses new[] { ... }. Consider using the newer collection expression syntax throughout for consistency.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test per #62782 (comment)
Also, readding
WebHostBuildertest that was converted toHostBuilderso we keep test coverage.